Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39751: Clarify where a warning comes from and hide it #854

Merged
merged 2 commits into from
Jun 22, 2023
Merged

DM-39751: Clarify where a warning comes from and hide it #854

merged 2 commits into from
Jun 22, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jun 21, 2023 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

timj added 2 commits June 21, 2023 16:53
@timj
Hide deprecation warnings coming from inside removeDatasetType
f7977c1 
The caller is not querying anything so they won't understand
why they are getting a warning.
@timj
Report warnings from user code rather than deep inside butler
34ac16c
@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c31cead) 88.01% compared to head (34ac16c) 88.01%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         269      269           
  Lines       35417    35423    +6     
  Branches     7423     7424    +1     
=======================================
+ Hits        31173    31179    +6     
  Misses       3103     3103           
  Partials     1141     1141
Impacted Files Coverage Δ
python/lsst/daf/butler/registries/sql.py 85.07% <100.00%> (+0.08%) ⬆️
.../butler/registry/datasets/byDimensions/_manager.py 93.65% <100.00%> (+0.03%) ⬆️
...ython/lsst/daf/butler/registry/obscore/_manager.py 82.65% <100.00%> (+0.10%) ⬆️
...ython/lsst/daf/butler/registry/obscore/_records.py 82.64% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

andy-slac
andy-slac approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@timj timj merged commit 50b5cb4 into main Jun 22, 2023
@timj timj deleted the tickets/DM-39751 branch June 22, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-slac andy-slac andy-slac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timj @andy-slac